Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-32: Dummy #282

Closed
wants to merge 5 commits into from
Closed

DFBUGS-32: Dummy #282

wants to merge 5 commits into from

Conversation

rewantsoni
Copy link
Member

dummy PR to test backport change

rewantsoni and others added 4 commits November 25, 2024 16:38
@rewantsoni
controllers: new controller for maintenance mode
7a9f546 
Signed-off-by: Rewant Soni <[email protected]>
@openshift-merge-bot
Merge pull request red-hat-storage#264 from rewantsoni/mmode
672e703 
controllers: new controller for maintenance mode
@rewantsoni
api: make inMaintenanceMode optional
3ab6f7f 
olm stops operator updates when a new field is introduced with
a required qualifer, hence we need to make it optional

Signed-off-by: Rewant Soni <[email protected]>
@openshift-merge-bot
Merge pull request red-hat-storage#281 from rewantsoni/fix-status
5ef26d8 
api: make inMaintenanceMode optional
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rewantsoni
Once this PR has been reviewed and has the lgtm label, please assign madhu-1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nikhil-Ladha Nikhil-Ladha changed the title Dummy DFBUGS-32: Dummy Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@rewantsoni: This pull request references [Jira Issue DFBUGS-32](https://issues.redhat.com//browse/DFBUGS-32), which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Obsolete) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

dummy PR to test backport change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rewantsoni
controllers: dummy PR
0361522 
Signed-off-by: Rewant Soni <[email protected]>
@rewantsoni
Copy link
Member Author

rewantsoni commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

/retitle DFBUGS-32: Dummy

@Nikhil-Ladha
Copy link
Member

Nikhil-Ladha commented Nov 26, 2024 •
edited
Loading

@hoxhaeris @bradmwilliams can you please check why the jira bot is not adding the labels for the PR in this repo?
We have the necessary labels in the repo though: https://github.com/red-hat-storage/ocs-client-operator/labels?q=jira

@hoxhaeris
Copy link

@hoxhaeris @bradmwilliams can you please check why the jira bot is not adding the labels for the PR in this repo? We have the necessary labels in the repo though: https://github.com/red-hat-storage/ocs-client-operator/labels?q=jira

Hi @Nikhil-Ladha, we'll have a look.

@hoxhaeris
Copy link

@Nikhil-Ladha , I've found the issue. The Jira plugin does not have access to this repository, hence the API call is failing with a 403. I'll check what needs to be done to fix this.

@hoxhaeris
Copy link

hoxhaeris commented Nov 26, 2024 •
edited
Loading

@Nikhil-Ladha, the bot (openshift-ci-bot) needs admin access to this repository for the labels to work properly. You'll need to grant this access yourself if you have the required permissions, or request it from the org/repo owners/admins.

@Nikhil-Ladha
Copy link
Member

@Nikhil-Ladha, the bot (openshift-ci-bot) needs admin access to this repository for the labels to work properly. You'll need to grant this access yourself if you have the required permissions, or request it from the org/repo owners/admins.

AFAIK, the bot already has admin access to all the repos in the red-hat-storage org.
But, I will still let @agarwal-mudit or @travisn help/confirm with this here.

@Nikhil-Ladha
Copy link
Member

From what I see, it is a part of the org: https://github.com/orgs/red-hat-storage/people?query=opens
And, that should work otherwise we would be seeing in other repos as well 🤔

@Nikhil-Ladha
Copy link
Member

Seems like we need to re-authenticate the bot for newly created repos.
I see the same issue for ceph-csi-operator repo as well: red-hat-storage/ceph-csi-operator#61

@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 26, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@nb-ohad: This pull request references [Jira Issue DFBUGS-32](https://issues.redhat.com//browse/DFBUGS-32), which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Obsolete) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 26, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@nb-ohad: This pull request references [Jira Issue DFBUGS-32](https://issues.redhat.com//browse/DFBUGS-32), which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Obsolete) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Nikhil-Ladha
Copy link
Member

The issue seems to be resolved now.
Thanks a lot @hoxhaeris for helping in sorting this issue out 🚀

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@rewantsoni: This pull request references [Jira Issue DFBUGS-32](https://issues.redhat.com//browse/DFBUGS-32). The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

dummy PR to test backport change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rewantsoni @openshift-ci-robot @Nikhil-Ladha @hoxhaeris @nb-ohad